-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dashboard to design v122 (Part 1) #9896
Conversation
Lots more refactors still need to be done so that both backends are always present
I guess I'll avoid stacking the move to tabs on top of this PR, as this is a big PR so there may be a lot of changes needed. |
![]()
![]() ![]()
![]()
![]()
![]()
|
uhoh |
fixed some things locally, some of them are still TODO:
|
@somebody1234 we can fix 7th on separate PR and then just fix 2nd issue here. Then we can push this to merge after all others are fixed |
found the cause of 2nd, was me being silly. @PabloBuchu should be ready for re-QA now - although now's probably not the best time, lol |
@MrFlashAccount just a note that this PR is blocked on your re-review |
QA passed. I created one small fix https://github.com/enso-org/cloud-v2/issues/1301 lets fix the merge conflict and try to merge it today @MrFlashAccount can you rereview and approve? |
⚠️ This PR depends on #9896 and MUST NOT be merged before that one. - Close #9898 - Move right menu to Drive View - Use new icon for toggling the menu - Move Search Bar into Drive View - both of these changes come with free simplifications to the code. - Refactor entire Top Bar to show pages as tabs - Fix enso-org/cloud-v2#1301 - Remove grey background from arrow icon visible when hovering over directory rows # Important Notes - Fonts containing slight variants have been added to make it match more closely with the Figma design. HOWEVER: - They have been added in `app/gui2` instead of the Dashboard codebase, because that is where the existing Enso font is located. - While it's definitely possible to put them in the Dashboard codebase, I think it's preferable to avoid that, otherwise we will have two separate mechanisms for loading/packaging fonts. - However, this problem SHOULD go away if (if not when) the entrypoints for the desktop app (in `app/gui2`) and cloud.enso.org (in `app/ide-desktop/lib/dashboard`) are merged.
Pull Request Description
Close Update the Dashboard to Newest Design #9886
Incidental changes
Important Notes
None
Code review tips
Testing instructions
Screencasts
dashboard-122.mp4
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
The documentation has been updated, if necessary.Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
Unit tests have been written where possible.