Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't recompute IR children #9915

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Don't recompute IR children #9915

wants to merge 1 commit into from

Commits on May 10, 2024

  1. Don't recompute IR children 

    Profiling benchmarks revealed that we spend non-neglible amount of time
building IR preorder which in turns recomputes IR nodes' children.
IR is immutable so there is not need to recompute that data for every
pass.
Note that the change uses `lazy val` because benchmarks weren't showing
much improvements when allocating children on creation (with `val`). We
could probably improve the situation by using a poor version of `lazy
val` that does not employ synchronization.
    @hubertp
    hubertp committed May 10, 2024
    Configuration menu
    Copy the full SHA
    63ea8aa View commit details
    Browse the repository at this point in the history