Error messages for rename_columns and Vector.duplicates
#9917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdunkerley
requested review from
radeusgd,
GregoryTravis and
AdRiley
as code owners
AdRiley
reviewed
May 10, 2024
AdRiley
reviewed
May 10, 2024
distribution/lib/Standard/Table/0.0.0-dev/src/Internal/Table_Helpers.enso
Outdated
Show resolved
Hide resolved
AdRiley
reviewed
May 10, 2024
| if map.size == mapping.length then rename_columns naming_helper internal_columns map case_sensitivity error_on_missing_columns on_problems else | ||
| duplicates = mapping.duplicates on=_.first . map .to_text | ||
| duplicate_text = duplicates.take 3 . to_vector . join ", " + (if duplicates.length > 3 then ", ..." + (duplicates.length - 3).to_text + " others" else "") | ||
| Error.throw (Illegal_Argument.Error "duplicate old name mappings ("+duplicate_text+").") |
AdRiley
approved these changes
May 10, 2024
GregoryTravis
approved these changes
May 10, 2024
Add `length` to `Set` and `Map`. Add `duplicates` to `Vector` (and `Array`).
jdunkerley
force-pushed
the
wip/jd/error-messages
branch
from
6cec1dc
to
8b9921e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
rename_columns.lengthtoSetandMap.duplicatestoVector(andArray).Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.