Skip to content
This repository has been archived by the owner on Dec 28, 2021. It is now read-only.

Losing LS connection will display a statusbar message. #1316

Merged
merged 3 commits into from
Mar 12, 2021
Merged

Losing LS connection will display a statusbar message. #1316

merged 3 commits into from
Mar 12, 2021

Conversation

mwu-tow
Copy link
Contributor

@mwu-tow mwu-tow commented Mar 11, 2021 •
edited by farmaazon

Pull Request Description

Important Notes

Checklist

Please include the following checklist in your PR:

  • The CHANGELOG.md was updated with the changes introduced in this PR.
  • The documentation has been updated if necessary.
  • All code conforms to the Rust style guide.
  • All code has automatic tests where possible.
  • All code has been profiled where possible.
  • All code has been manually tested in the IDE.
  • All code has been manually tested in the "debug/interface" scene.
  • All code has been manually tested by the PR owner against our test scenarios.
  • All code has been manually tested by at least one reviewer against our test scenarios.

@mwu-tow mwu-tow marked this pull request as ready for review March 11, 2021 14:43
farmaazon
farmaazon reviewed Mar 11, 2021
View reviewed changes
Copy link
Collaborator

@farmaazon farmaazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good to me. I will test it tomorrow.

@mwu-tow mwu-tow merged commit 01f481e into develop Mar 12, 2021
@mwu-tow mwu-tow deleted the wip/mwu/statusbar-disconnection-message branch March 12, 2021 11:56
mwu-tow added a commit to enso-org/enso that referenced this pull request Oct 30, 2021
@mwu-tow
Losing LS connection will display a statusbar message. (enso-org/ide#…
b6e9de1 
…1316)

Original commit: enso-org/ide@01f481e
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wdanilo wdanilo wdanilo approved these changes

@farmaazon farmaazon farmaazon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mwu-tow @wdanilo @farmaazon