This repository has been archived by the owner on Dec 28, 2021. It is now read-only.
Engine updates after adding node: send import first, then the new node #1332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the user creates a node through the searcher that needs additional imports, those imports should be added before or simultaneously to the node content to avoid an invalid intermediate state. This was done in the wrong order before this commit.
s9ferech
added
Category: Controllers
[ci no changelog needed]
farmaazon
approved these changes
Mar 17, 2021
farmaazon
suggested changes
Mar 17, 2021
CHANGELOG.md
Outdated
Comment on lines
40
to
43
| - [Inform the engine about new imports before they are used][#1332]. When the | ||
| user adds or changes a node through the searcher, the necessary imports are | ||
| added first, the node content afterwards. This avoids an invalid intermediate | ||
| state. |
There was a problem hiding this comment.
The changelog should be more user-facing: most users do not know what is the Engine. Probably it should be like "Fix flashing import error after adding a node".
There was a problem hiding this comment.
I do not even know what the exact problem for the user was. Could you write the changelog then?
farmaazon
approved these changes
Mar 19, 2021
wdanilo
approved these changes
Mar 23, 2021
mwu-tow
pushed a commit
to enso-org/enso
that referenced
this pull request
Oct 30, 2021
enso-org/ide#1332) When the user creates a node through the searcher that needs additional imports, those imports should be added before or simultaneously to the node content to avoid an invalid intermediate state. This was done in the wrong order before this commit. Original commit: enso-org/ide@da6d66f
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This solves issue #1326. When the user creates a node through the searcher that needs additional imports, those imports should be added before or simultaneously to the node content to avoid an invalid intermediate state. This was done in the wrong order before this commit.
Important Notes
Checklist
Please include the following checklist in your PR:
TheCHANGELOG.mdwas updated with the changes introduced in this PR.The documentation has been updated if necessary.All code has been profiled where possible.All code has been manually tested in the "debug/interface" scene.