This repository has been archived by the owner on Dec 28, 2021. It is now read-only.
Run all backend processed even if the IDE package is run with --no-window #1353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelMauderer
added
Good First Issue
MichaelMauderer
force-pushed
the
wip/mm/fix-no-window-arg
branch
from
1d0f4d9
to
4936ba7
Compare
wdanilo
approved these changes
Mar 22, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Previously
--no-windowwould skip the whole IDE main function. This is no more localized: we run the language server and IDE service, but skip opening a window.Checklist
Please include the following checklist in your PR:
CHANGELOG.mdwas updated with the changes introduced in this PR.All code has automatic tests where possible.All code has been manually tested in the "debug/interface" scene.All code has been manually tested by the PR owner against our test scenarios.All code has been manually tested by at least one reviewer against our test scenarios.