Visual improvements 2 #1419
Visual improvements 2 #1419
Conversation
| /// The overall entry's height (including padding). | ||
| pub const HEIGHT:f32 = 30.0; | ||
| /// The text size of entry's labe. | ||
| pub const LABEL_SIZE:f32 = 12.0; | ||
| /// The size in pixels of icons inside entries. | ||
| pub const ICON_SIZE:f32 = 0.0; // TODO[ao] restore when created some icons for searcher. | ||
| /// The gap between icon and label. | ||
| pub const ICON_LABEL_GAP:f32 = 7.0; | ||
| pub const ICON_LABEL_GAP:f32 = 0.0; // TODO[ao] restore when created some icons for searcher. |
There was a problem hiding this comment.
What does the sentence mean? "Restore" means to do something in the future. While "when created" is in the past. I don't understand it.
There was a problem hiding this comment.
I copied the comment from above. The searcher was at some point meant to contain icons. It does not at the moment, so these paddings sand gaps need to be 0 now, but they need to be set when we add icons. I've fixed the grammar, now.
src/rust/ensogl/lib/core/src/display/shape/primitive/style_watch.rs
Outdated
Show resolved
Hide resolved
| @@ -275,7 +285,7 @@ define_themes! { [light:0, dark:1] | |||
| highlight = selection , selection; | |||
| text = Lcha(0.0,0.0,0.0,0.7) , Lcha(1.0,0.0,0.0,0.7); | |||
| text { | |||
| highlight = Lcha(0.8,0.0,0.0,1.0) , Lcha(0.7,0.0,0.0,1.0); | |||
| highlight = Lcha(0.7,0.4,0.74,1.0) , Lcha(0.7,0.4,0.74,1.0); | |||
There was a problem hiding this comment.
do not hardcode values, link them to other places in the stylesheet if possible. (see my previous comment)
There was a problem hiding this comment.
I don't think we have a matching value here. This is for the blue highlight in the searcher.
src/rust/ide/view/graph-editor/src/component/node/action_bar.rs
Outdated
Show resolved
Hide resolved
| // Note: Disabled for https://github.com/enso-org/ide/issues/1397 | ||
| // Re-enable when they are needed again. |
There was a problem hiding this comment.
This comment tells nothing about this change. It just tells that this is "dsiabled" and was disabled as part of "visual improvements" and it should be re-enabled "when needed again". Such comments should be descriptive, in particular - why it is disabled (because these icons were useless now) and what does it mean "needed again" - when icons willbecome implemented properly + it should have link to issue about that (fixing / finishing the icons skip + freeze)
There was a problem hiding this comment.
Found the related issue and linked it. Expanded the description.
src/rust/ide/view/graph-editor/src/component/node/action_bar.rs
Outdated
Show resolved
Hide resolved
Original commit: enso-org/ide@1fa34b0
Pull Request Description
More Visual improvements
Peek.2021-04-01.14-41.mp4
Checklist
Please include the following checklist in your PR:
CHANGELOG.mdwas updated with the changes introduced in this PR.All code has automatic tests where possible.All code has been profiled where possible.