Skip to content
This repository has been archived by the owner on Dec 28, 2021. It is now read-only.

Undo Redo — Part 1 #1602

Merged
merged 18 commits into from Jun 11, 2021
Merged

Undo Redo — Part 1 #1602

merged 18 commits into from Jun 11, 2021

Conversation

mwu-tow
Copy link
Collaborator

@mwu-tow mwu-tow commented Jun 5, 2021

Pull Request Description

First part of Undo-Redo. Missing parts are:

  • proper Text Editor support;
  • proper handling of deleting nodes;
  • undoing some UI actions (like node selection, active visualization, switching view to a different graph).

Otherwise graph operations should work with undo-redo reasonably well.

Important Notes

Checklist

Please include the following checklist in your PR:

  • The CHANGELOG.md was updated with the changes introduced in this PR.
  • The documentation has been updated if necessary.
  • All code conforms to the Rust style guide.
  • All code has automatic tests where possible.
    - [ ] All code has been profiled where possible.
  • All code has been manually tested in the IDE.
    - [ ] All code has been manually tested in the "debug/interface" scene.
  • All code has been manually tested by the PR owner against our test scenarios.
  • All code has been manually tested by at least one reviewer against our test scenarios.

@mwu-tow mwu-tow changed the title Undo Redo — Part 1 [WIP] Undo Redo — Part 1 Jun 5, 2021
@mwu-tow mwu-tow marked this pull request as ready for review June 7, 2021 03:31
@mwu-tow mwu-tow changed the title [WIP] Undo Redo — Part 1 Undo Redo — Part 1 Jun 7, 2021
src/rust/ensogl/lib/components/src/selector/bounds.rs Outdated Show resolved Hide resolved
src/rust/ide/lib/parser/src/api.rs Outdated Show resolved Hide resolved
src/rust/ide/src/controller/graph.rs Outdated Show resolved Hide resolved
src/rust/ide/src/double_representation/module.rs Outdated Show resolved Hide resolved
src/rust/ide/src/ide/integration.rs Outdated Show resolved Hide resolved
src/rust/ide/src/model/project.rs Outdated Show resolved Hide resolved
src/rust/ide/src/model/undo_redo.rs Outdated Show resolved Hide resolved
src/rust/ide/src/model/undo_redo.rs Outdated Show resolved Hide resolved
src/rust/ide/src/model/undo_redo.rs Outdated Show resolved Hide resolved
src/rust/ide/src/model/undo_redo.rs Outdated Show resolved Hide resolved
Copy link
Member

@wdanilo wdanilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm skipping this PR, as it touches files I don't know about.

@farmaazon farmaazon merged commit 28ad042 into develop Jun 11, 2021
@farmaazon farmaazon deleted the wip/mwu/undo-redo branch June 11, 2021 04:34
mwu-tow added a commit to enso-org/enso that referenced this pull request Oct 30, 2021
Missing parts are:
* proper Text Editor support;
* proper handling of deleting nodes;
* undoing some UI actions (like node selection, active visualization, switching view to a different graph).


Original commit: enso-org/ide@28ad042
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants