Skip to content
This repository has been archived by the owner on Dec 28, 2021. It is now read-only.

User Authentication in IDE #1653

Merged
merged 18 commits into from Jul 6, 2021
Merged

User Authentication in IDE #1653

merged 18 commits into from Jul 6, 2021

Conversation

4e6
Copy link
Contributor

@4e6 4e6 commented Jul 1, 2021

Pull Request Description

close #1635

Add authentication and minimum supported version check.

2021-07-01-175030_1547x656_scrot

Changelog:

  • feat: user authentication
    • User has to sign in before using the app.
    • Available auth methods: Google, GitHub, email with confirmation.
    • After successful authentication user's email is logged in the Mixpanel.
  • feat: check the minimum supported app version
    • App compares the current version with the minimum supported version and shows the message if the app version is lower.
    • Minimum supported version is downloaded from GitHub. File config.json on the development branch.
    • Application version is taken from package.json of the client js module (/src/js/lib/package.json)

Important Notes

Checklist

Please include the following checklist in your PR:

  • The CHANGELOG.md was updated with the changes introduced in this PR.
  • The documentation has been updated if necessary.
  • All code conforms to the Rust style guide.
  • All code has automatic tests where possible.
  • All code has been profiled where possible.
  • All code has been manually tested in the IDE.
  • All code has been manually tested in the "debug/interface" scene.
  • All code has been manually tested by the PR owner against our test scenarios.
  • All code has been manually tested by at least one reviewer against our test scenarios.

@4e6 4e6 added Difficulty: Core Contributor Should only be attempted by a core contributor Priority: High Should be scheduled as soon as possible Type: Enhancement An enhancement to the current state of Enso IDE Category: GUI The Graphical User Interface labels Jul 1, 2021
@4e6 4e6 self-assigned this Jul 1, 2021
@4e6 4e6 marked this pull request as ready for review July 1, 2021 15:21
@4e6 4e6 requested a review from wdanilo as a code owner July 1, 2021 15:21
Copy link
Member

@wdanilo wdanilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will be releasing that to a big audience next week. Please triple check that with Marcin (he is sick but if you write to him to double check it, e'd probably do it) if the emails are correctly logged to mixpanel.

Comment on lines +474 to +483
/// Set custom user agent to fix the issue with Google authentication.
///
/// Google authentication doesn't work with the default Electron user agent. And
/// Google is quite picky about the values you provide. For example, just
/// removing Electron occurrences from the default user agent doesn't work. This
/// user agent was chosen by trial and error as a stable one.
///
/// https://github.com/firebase/firebase-js-sdk/issues/2478
function setUserAgent() {
const agent = 'Mozilla/5.0 (Windows NT 10.0; WOW64; rv:70.0) Gecko/20100101 Firefox/70.0'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so strange. It's ok, just strange

src/js/lib/content/firebase.yaml Outdated Show resolved Hide resolved
src/js/lib/content/src/index.html Outdated Show resolved Hide resolved
src/js/lib/content/src/index.html Outdated Show resolved Hide resolved
src/js/lib/content/src/index.ts Outdated Show resolved Hide resolved
src/js/lib/content/src/index.ts Outdated Show resolved Hide resolved
src/js/lib/content/src/index.ts Outdated Show resolved Hide resolved
src/js/lib/content/src/index.ts Outdated Show resolved Hide resolved
src/js/lib/content/src/index.ts Outdated Show resolved Hide resolved
src/js/lib/content/src/index.ts Outdated Show resolved Hide resolved
@4e6 4e6 merged commit 2e2a804 into develop Jul 6, 2021
@4e6 4e6 deleted the wip/db/authentication branch July 6, 2021 10:00
mwu-tow pushed a commit to enso-org/enso that referenced this pull request Oct 30, 2021
Add authentication and minimum supported version check

Original commit: enso-org/ide@2e2a804
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Category: GUI The Graphical User Interface Difficulty: Core Contributor Should only be attempted by a core contributor Priority: High Should be scheduled as soon as possible Type: Enhancement An enhancement to the current state of Enso IDE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User Authentication
2 participants