Skip to content
This repository has been archived by the owner on Dec 28, 2021. It is now read-only.

Emit correct events when deselecting all nodes. #1664

Merged
merged 2 commits into from Jul 6, 2021
Merged

Emit correct events when deselecting all nodes. #1664

merged 2 commits into from Jul 6, 2021

Conversation

MichaelMauderer
Copy link
Contributor

@MichaelMauderer MichaelMauderer commented Jul 5, 2021 •
edited

Pull Request Description

Fix nodes not being correctly deselected.

Checklist

Please include the following checklist in your PR:

  • The CHANGELOG.md was updated with the changes introduced in this PR.
  • The documentation has been updated if necessary.
  • All code conforms to the Rust style guide.
  • All code has automatic tests where possible.
  • All code has been profiled where possible.
  • All code has been manually tested in the IDE.
  • All code has been manually tested in the "debug/interface" scene.
  • All code has been manually tested by the PR owner against our test scenarios.
  • All code has been manually tested by at least one reviewer against our test scenarios.

@MichaelMauderer MichaelMauderer added Priority: Highest Should be completed ASAP Category: GUI The Graphical User Interface Type: Regression A bug that was not present in previous release. labels Jul 5, 2021
@MichaelMauderer MichaelMauderer self-assigned this Jul 5, 2021
@MichaelMauderer MichaelMauderer force-pushed the wip/mm/node_selection_and_movement_fix branch from 3dee580 to b1bd2a6 Compare July 5, 2021 15:09
@MichaelMauderer MichaelMauderer marked this pull request as ready for review July 5, 2021 15:13
@MichaelMauderer MichaelMauderer changed the title Emmit correct events when deselecting all nodes. Emit correct events when deselecting all nodes. Jul 6, 2021
@MichaelMauderer MichaelMauderer merged commit 63ff1fe into develop Jul 6, 2021
@MichaelMauderer MichaelMauderer deleted the wip/mm/node_selection_and_movement_fix branch July 7, 2021 11:57
mwu-tow pushed a commit to enso-org/enso that referenced this pull request Oct 30, 2021
@MichaelMauderer
Emit correct events when deselecting all nodes. (enso-org/ide#1664)
8a87fcd 
Original commit: enso-org/ide@63ff1fe
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@farmaazon farmaazon Awaiting requested review from farmaazon

@wdanilo wdanilo Awaiting requested review from wdanilo wdanilo is a code owner

Assignees

@MichaelMauderer MichaelMauderer

Labels
Category: GUI The Graphical User Interface Priority: Highest Should be completed ASAP Type: Regression A bug that was not present in previous release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@MichaelMauderer