Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translation labels and datepicker #20

Merged
merged 1 commit into from
Apr 29, 2020
Merged

Conversation

heyner29
Copy link
Contributor

No description provided.

@aocneanu
Copy link
Contributor

@heyner29 lol, did you discover the internal filters? 🗡️

Please give me feedback on this, and note that it's still experimental.

@aocneanu aocneanu merged commit efbf775 into enso-ui:master Apr 29, 2020
@heyner29
Copy link
Contributor Author

If I like to review a little behind each commit. I found the function and wanted to test it XD
At the moment it looks very cool, I understand how you say that it is still experimental, but it looks very good. At the moment the only thing I have to provide additional is that the interval of dates allows to select as a maximum date one prior to the minimum. I know it's a matter of logic as a user not to do it, but with users you don't know jejeje

image

And it has the same bug that the interval filter had when selecting the maximum day it should be 23:59:59 in order for the records of the maximum day to appear, otherwise they will not appear.

image

image

And finally, clicking to change the month or year closes the filter without being able to make the selection.

I will continue to review and try to contribute in commits or feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants