Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading indirect package dependencies with Yarn (question) #80

Closed
robbykrlos opened this issue Apr 7, 2021 · 4 comments
Closed

Upgrading indirect package dependencies with Yarn (question) #80

robbykrlos opened this issue Apr 7, 2021 · 4 comments

Comments

@robbykrlos
Copy link

This is a question.

Hi,

Stupid question maybe but I'm interested how you guys keep things updated on UI.

So I'm dealing with this yarn issue, where yarn will not update your indirect package dependencies. Let's take enso-ui/ui, which is inside my package.json (^4.0).
enso-ui/ui has inside in it's package.json a dependecy with enso-ui/toastr (^2.0).

I want to update update only enso-ui/toastr from 2.1.1 (what is in my yarn.lock file) to recent 2.1.2.

I do not want to update enso-ui/ui with full dependencies, just enso-ui/toastr.
I also do not consider adequate to yarn add enso-ui/toastr to my local package.json
I also do not consider adequate to manually change the yarn.lock file.

I found this workaround:

yarnpkg/yarn#4986 (comment) - delete yarn.lock entry for enso-ui/toastr and run yarn again, forcing latest version.

Do you have this issue, or you always go for enso-ui/ui upgrade with full dependencies?

@robbykrlos robbykrlos changed the title Upgrading indirect package dependencies with Yarn Upgrading indirect package dependencies with Yarn (question) Apr 7, 2021
@aocneanu
Copy link
Contributor

aocneanu commented Apr 7, 2021

we should delete yarn.lock from all packages asap:). We only need one in the local project.

@robbykrlos
Copy link
Author

I don't get it:) there is no yarn.lock in any of your enso-ui sub-packages. I only have the one in my local project.

@aocneanu
Copy link
Contributor

aocneanu commented Apr 7, 2021

I believe I might have read your post in too much of a hurry. We always try to keep enso-ui/ui up to date with all the deps.

@robbykrlos
Copy link
Author

I believe I might have read your post in too much of a hurry. We always try to keep enso-ui/ui up to date with all the deps.

No worries, thanks for the quick reply.

Ideally that's normal, but sometimes changes are not inter-linked so sub-package upgrade makes sense too.

Have a good day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants