ogent / ent - type generation problems

[thmeitz]

• [ x ] The issue is present in the latest release.
• [ x ] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

1. ogent generates wrong type
   schema.go definition field.Uint32("id").StorageKey("client_id"),
ogent generates int32 type

• see: one of the 600 errors in the example repo

2. ent generation problem if table contains table column

• see: https://github.com/thmeitz/entisp/blob/647e31671d6a07919c4ab19d210c8b1b14923e37/ent/iptable/where.go#L102

3. ent generation problem if table name is client
   renamed schema to customer in example repo. rename it back to client and you'll get a go generate error
4. ogent req.TmpData.Get undefined (type []byte has no field or method Get)

• NewOptByteSlice will not be generated by ogent
• see: https://github.com/thmeitz/entisp/blob/3c4366726268c071416b9815ce0205e0d5554200/ent/ogent/responses.go#L860

5. Follow-up error in openapi.json - generates also int32 type

Expected Behavior 🤔

1. expecting type uint32
2. expecting thats using a pre- or suffix? dont have an idea how we should fix this
3. expecting thats working (see 2.)
4. NewOptByteSlice should be generated
5. expecting uint32 in openapi.json

Steps to Reproduce 🕹

Steps:

1. checkout the repo ispent

Your Environment 🌎

Tech	Version
Go	1.18
Ent	v0.10.2-0.20220321093754-edd968490ea2

[a8m]

Thanks for reporting this issue @thmeitz 🙏

One of us will give it a look next week.

[masseelch]

Hey @thmeitz,

1. OpenAPI does not allow unsigned integers. However, for unsigned int we should add a min value of 0 and fix the bug you detected.
2. The llinked PR now skips generation of the Table predicate
3. Some keywords are used internally, Client being one of them. I extended the documentation to mention this as well.
4. Fixed in the linked PR
5. See 1

[masseelch]

@thmeitz The lates master of each (ent, contrib, ogent) have now all the issues resolved. I saw your issue in entimport and will make sure we address that one soon as well :-)

If you need anything more, don't hesitate to ask.