Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

entoas: add minimum property to uint types #287

Merged
merged 2 commits into from
Apr 21, 2022
Merged

entoas: add minimum property to uint types #287

merged 2 commits into from
Apr 21, 2022

Conversation

masseelch
Copy link
Collaborator

@masseelch masseelch commented Apr 20, 2022 •
edited

@masseelch masseelch requested review from a8m and rotemtam April 20, 2022 14:49
a8m
a8m approved these changes Apr 20, 2022
View reviewed changes
entoas/generator.go Outdated
}
var (
min int64
_types = map[string]*ogen.Schema{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the _?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. When I wrote it there was a lot of Dart code on my desk as well, you unexport members by "_" there.

@masseelch masseelch force-pushed the entoas/minimum_value_for_uint branch from 0350baf to 0c86da1 Compare April 20, 2022 14:54
@masseelch masseelch merged commit 565528d into master Apr 21, 2022
@masseelch masseelch deleted the entoas/minimum_value_for_uint branch April 21, 2022 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a8m a8m a8m approved these changes

@rotemtam rotemtam Awaiting requested review from rotemtam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@masseelch @a8m