Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a option to disable the generation of generate.go in ent/contrib/entproto #3508

Closed
1 task done
Zxilly opened this issue Apr 29, 2023 · 2 comments · Fixed by ent/contrib#499
Closed
1 task done
Assignees
Labels

Comments

@Zxilly
Copy link

Zxilly commented Apr 29, 2023

  • I have searched the issues of this repository and believe that this is not a duplicate.

Summary 💡

As for now, entproto only have one option called WithProtoDir(dir string) to set the proto dir. I wonder is that possible to provide another option to disable the generation of generate.go.
We have other tools to handle proto compilation, thus no need for this file. And we have to manually delete it each time after ent genetate.

Motivation 🔦

protoExt, _ := entproto.NewExtension(entproto.WithProtoDir(""), entproto.WithEnableProtoGenerateHelper(false))
@rotemtam
Copy link
Collaborator

Hi @Zxilly

Thanks for reaching out. I’m in favor of adding such an option to entproto. Would you like to contribute this change ? I’m happy to guide you through the process

@Zxilly
Copy link
Author

Zxilly commented Apr 29, 2023

I can make a PR after May.15. Before that I have some other thing to deal with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants