entc/gen/template: add GoLand annotation for template data-types #1444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @alexsn |
giautm
reviewed
Apr 9, 2021
| @@ -17,7 +19,7 @@ import ( | |||
| "entgo.io/ent/dialect/sql" | |||
| ) | |||
|
|
|||
| {{ range $_, $n := $.Nodes -}} | |||
| {{ range $n := $.Nodes -}} | |||
There was a problem hiding this comment.
hey @a8m, I believe this fix is wrong. See: https://play.golang.org/p/TXAOkWN43pp
There was a problem hiding this comment.
The range clause works a bit different in templates (see the text/template doc):
Note that if there is only one variable, it is assigned the element; this is opposite to the convention in Go range clauses.
But I still appreciate the review. Thanks 馃檹
There was a problem hiding this comment.
Yeah, I have checked the doc but missed the note. :)))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃く 馃く 馃く 馃く 馃く 馃く 馃く 馃く 馃く 馃く 馃く 馃く 馃く 馃く
This annotation enables the auto-completion of templates in GoLand.