Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write a document for custom formatter of migrate #2415

Merged
merged 7 commits into from Mar 25, 2022
Merged

Conversation

iwata
Copy link
Contributor

@iwata iwata commented Mar 19, 2022

SSIA
Related to this issue #2408.

Copy link
Collaborator

@masseelch masseelch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @iwata, great start, thank you!

I added some minor comments. Additionally, I think we should try to give the users more ready-to-copy code to reduce friction when using a custom formatter.

I think a good idea would be to copy this code snippet and add the changes needed for the gooseFormatter and highlight them, WDYT? .

doc/md/versioned-migrations.md Outdated Show resolved Hide resolved
doc/md/versioned-migrations.md Outdated Show resolved Hide resolved
doc/md/versioned-migrations.md Outdated Show resolved Hide resolved
iwata and others added 3 commits March 21, 2022 19:25
Co-authored-by: MasseElch <12862103+masseelch@users.noreply.github.com>
Co-authored-by: MasseElch <12862103+masseelch@users.noreply.github.com>
@iwata iwata requested a review from masseelch March 22, 2022 02:22
@iwata
Copy link
Contributor Author

iwata commented Mar 22, 2022

@masseelch

I added some minor comments. Additionally, I think we should try to give the users more ready-to-copy code to reduce friction when using a custom formatted.

Thanks, and committed to your suggestions.

I think a good idea would be to copy this code snippet and add the changes needed for the gooseFormatter and highlight them, WDYT? .

GOTCHA 👍
I've updated the code sample, so PTAL.

@iwata
Copy link
Contributor Author

iwata commented Mar 25, 2022

@masseelch Can you check this?

@masseelch
Copy link
Collaborator

@masseelch Can you check this?

Yes, of course. Somehow this slipped my attention, sorry!

Copy link
Collaborator

@masseelch masseelch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will merge after those suggestions :-) Thanks!

doc/md/versioned-migrations.md Outdated Show resolved Hide resolved
doc/md/versioned-migrations.md Outdated Show resolved Hide resolved
Co-authored-by: MasseElch <12862103+masseelch@users.noreply.github.com>
Copy link
Collaborator

@masseelch masseelch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot one part. That is why I removed the first one

doc/md/versioned-migrations.md Outdated Show resolved Hide resolved
iwata and others added 2 commits March 26, 2022 00:05
Co-authored-by: MasseElch <12862103+masseelch@users.noreply.github.com>
Co-authored-by: MasseElch <12862103+masseelch@users.noreply.github.com>
@iwata
Copy link
Contributor Author

iwata commented Mar 25, 2022

Forgot one part. That is why I removed the first one

Ah hah, I finally understand 😄

@masseelch masseelch merged commit e1e47e6 into ent:master Mar 25, 2022
@masseelch
Copy link
Collaborator

masseelch commented Mar 25, 2022

@all-contributors please add @iwata for doc.

@allcontributors
Copy link
Contributor

@masseelch

I've put up a pull request to add @iwata! 🎉

gitlawr pushed a commit to gitlawr/ent that referenced this pull request Apr 13, 2022
* Write a document for custom formatter of migrate

closes ent#2408

* Update doc/md/versioned-migrations.md

Co-authored-by: MasseElch <12862103+masseelch@users.noreply.github.com>

* Update doc/md/versioned-migrations.md

Co-authored-by: MasseElch <12862103+masseelch@users.noreply.github.com>

* more helpful code snippet

* Update doc/md/versioned-migrations.md

Co-authored-by: MasseElch <12862103+masseelch@users.noreply.github.com>

* Update doc/md/versioned-migrations.md

Co-authored-by: MasseElch <12862103+masseelch@users.noreply.github.com>

* Update doc/md/versioned-migrations.md

Co-authored-by: MasseElch <12862103+masseelch@users.noreply.github.com>

Co-authored-by: MasseElch <12862103+masseelch@users.noreply.github.com>
gitlawr pushed a commit to seal-io/ent that referenced this pull request Apr 13, 2022
* Write a document for custom formatter of migrate

closes ent#2408

* Update doc/md/versioned-migrations.md

Co-authored-by: MasseElch <12862103+masseelch@users.noreply.github.com>

* Update doc/md/versioned-migrations.md

Co-authored-by: MasseElch <12862103+masseelch@users.noreply.github.com>

* more helpful code snippet

* Update doc/md/versioned-migrations.md

Co-authored-by: MasseElch <12862103+masseelch@users.noreply.github.com>

* Update doc/md/versioned-migrations.md

Co-authored-by: MasseElch <12862103+masseelch@users.noreply.github.com>

* Update doc/md/versioned-migrations.md

Co-authored-by: MasseElch <12862103+masseelch@users.noreply.github.com>

Co-authored-by: MasseElch <12862103+masseelch@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants