New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write a document for custom formatter of migrate #2415
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @iwata, great start, thank you!
I added some minor comments. Additionally, I think we should try to give the users more ready-to-copy code to reduce friction when using a custom formatter.
I think a good idea would be to copy this code snippet and add the changes needed for the gooseFormatter
and highlight them, WDYT? .
Co-authored-by: MasseElch <12862103+masseelch@users.noreply.github.com>
Co-authored-by: MasseElch <12862103+masseelch@users.noreply.github.com>
Thanks, and committed to your suggestions.
GOTCHA 👍 |
@masseelch Can you check this? |
Yes, of course. Somehow this slipped my attention, sorry! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will merge after those suggestions :-) Thanks!
Co-authored-by: MasseElch <12862103+masseelch@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot one part. That is why I removed the first one
Co-authored-by: MasseElch <12862103+masseelch@users.noreply.github.com>
Co-authored-by: MasseElch <12862103+masseelch@users.noreply.github.com>
Ah hah, I finally understand 😄 |
@all-contributors please add @iwata for doc. |
I've put up a pull request to add @iwata! 🎉 |
* Write a document for custom formatter of migrate closes ent#2408 * Update doc/md/versioned-migrations.md Co-authored-by: MasseElch <12862103+masseelch@users.noreply.github.com> * Update doc/md/versioned-migrations.md Co-authored-by: MasseElch <12862103+masseelch@users.noreply.github.com> * more helpful code snippet * Update doc/md/versioned-migrations.md Co-authored-by: MasseElch <12862103+masseelch@users.noreply.github.com> * Update doc/md/versioned-migrations.md Co-authored-by: MasseElch <12862103+masseelch@users.noreply.github.com> * Update doc/md/versioned-migrations.md Co-authored-by: MasseElch <12862103+masseelch@users.noreply.github.com> Co-authored-by: MasseElch <12862103+masseelch@users.noreply.github.com>
* Write a document for custom formatter of migrate closes ent#2408 * Update doc/md/versioned-migrations.md Co-authored-by: MasseElch <12862103+masseelch@users.noreply.github.com> * Update doc/md/versioned-migrations.md Co-authored-by: MasseElch <12862103+masseelch@users.noreply.github.com> * more helpful code snippet * Update doc/md/versioned-migrations.md Co-authored-by: MasseElch <12862103+masseelch@users.noreply.github.com> * Update doc/md/versioned-migrations.md Co-authored-by: MasseElch <12862103+masseelch@users.noreply.github.com> * Update doc/md/versioned-migrations.md Co-authored-by: MasseElch <12862103+masseelch@users.noreply.github.com> Co-authored-by: MasseElch <12862103+masseelch@users.noreply.github.com>
SSIA
Related to this issue #2408.