doc/md - added usage note for golang-migrate #2482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thmeitz
changed the title
|
Thanks for the contribution @thmeitz 🙏 |
|
🙏 |
masseelch
reviewed
Apr 19, 2022
doc/md/versioned-migrations.md
Outdated
|
|
||
| Without the `multiStatements=true` parameter, the migration will fail if there is more than one SQL statement in the migration file. | ||
|
|
||
| Please note that all other options you use for your DSN must be added as well! |
There was a problem hiding this comment.
I'd drop this sentence and change the above to something like "you need to add the multiStatements parameter to true as in the example below" and then take the DSN we used in the documents with the param applied. WDYT?
There was a problem hiding this comment.
I'm fine with your change.
masseelch
approved these changes
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.