dialect/sql/schema: file based type store #2644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, I'm getting |
Good catch. I will both add a test and a fix for that :-) |
This PR adds support for a file based type storage when using versioned migrations. The file called `.ent_types` is written to the migration directory alongside the migration files and will be kept in sync for every migration file generation run. In order to not break existing code, where the type storage might differ for different deployment, global unique ID mut be enabled by using a new option. This will also be raised as an error to the user when attempting to use versioned migrations and global unique ID. Documentation will be added to this PR once feedback on the code is gathered.
masseelch
force-pushed
the
versioned/global-unique-id
branch
from
8eeb23c
to
3e8ea0a
Compare
a8m
reviewed
Jun 14, 2022
a8m
reviewed
Jun 14, 2022
a8m
reviewed
Jun 14, 2022
a8m
reviewed
Jun 14, 2022
|
Looks good 🚀 Please, fix the broken tests and I'll approve. |
masseelch
force-pushed
the
versioned/global-unique-id
branch
from
dda6d53
to
d93b55d
Compare
|
Currently this PR is blocked on a checksum problem: cc @a8m |
masseelch
force-pushed
the
versioned/global-unique-id
branch
2 times, most recently
from
1e93cfe
to
61b601f
Compare
masseelch
force-pushed
the
versioned/global-unique-id
branch
2 times, most recently
from
7142c03
to
bef944e
Compare
masseelch
force-pushed
the
versioned/global-unique-id
branch
from
bef944e
to
85f1948
Compare
a8m
approved these changes
Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for a file based type storage when using versioned migrations. The file called
.ent_typesis written to the migration directory alongside the migration files and will be kept in sync for every migration file generation run.In order to not break existing code, where the type storage might differ for different deployment, global unique ID mut be enabled by using a new option. This will also be raised as an error to the user when attempting to use versioned migrations and global unique ID.
Documentation will be added to this PR once feedback on the code is gathered.
Fixes #2587
I have discussed with Ariel already, that we will move the configuration for allocated pk ranges to the schema level. We haven't yet figured out, how to do this best, but it will come.