dialect/sql/builder: make sql.In() with empty args fallback to False() #2735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a8m
reviewed
Jul 11, 2022
| return p | ||
| return p.False() |
There was a problem hiding this comment.
Small comment, can you please copy the comment from here:
https://github.com/ent/ent/blob/master/entc/gen/template/dialect/sql/predicate.tmpl#L21-L22
There was a problem hiding this comment.
We can also remove this if-statement from the codegen.
There was a problem hiding this comment.
We can also remove this if-statement from the codegen.
Really agreed, fixed in 52c502b 🙏
| return p | ||
| return p.False() |
There was a problem hiding this comment.
Suggested change
| return p | |
| return p.False() | |
| // If no arguments were provided, append the FALSE constants, | |
| // since we can't apply "IN ()". This will make this predicate falsy. | |
| return p.False() |
There was a problem hiding this comment.
thanks added in f1fcc1c 👍
a8m
reviewed
Jul 11, 2022
dialect/sql/builder.go
Outdated
| @@ -1535,8 +1535,10 @@ func In(col string, args ...interface{}) *Predicate { | |||
|
|
|||
| // In appends the `IN` predicate. | |||
| func (p *Predicate) In(col string, args ...interface{}) *Predicate { | |||
| // if not arguments were provided, append the FALSE constants, | |||
There was a problem hiding this comment.
Suggested change
| // if not arguments were provided, append the FALSE constants, | |
| // If no arguments were provided, append the FALSE constants, |
a8m
reviewed
Jul 11, 2022
| if len({{ $arg }}) == 0 { | ||
| s.Where(sql.False()) | ||
| return | ||
| } |
There was a problem hiding this comment.
Run go generate ./... from the root of the project.
|
thanks for the review 🙌 |
adayNU
added a commit
to adayNU/ent
that referenced
this pull request
Jul 14, 2022
…se() This is basically the identical change to ent#2735, but for NotIn(). This bug currently prevents anyone using NotIn() from upgrading from v0.10.x to v0.11.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encountered a SQL syntax error when executing
sql.In("col", []interface{}). The new test case compiles into"SELECT * FROM "users" WHERE "a" = $1 OR"without this PR change.entc generated code at
ent/<modelname>/where.gohas the sameFALSEfallback logic butsql.Indidn't, and I'm assuming this is not the expected behavior.