dialect/sql/schema: no longer allocate a PK range for a join table #2950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masseelch
changed the title
masseelch
force-pushed
the
remove_join_table_from_types_table
branch
from
1e7d159
to
b8e160e
Compare
masseelch
changed the title
masseelch
force-pushed
the
remove_join_table_from_types_table
branch
from
05e0023
to
10f30f9
Compare
a8m
approved these changes
Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not entirely sure yet we have to add some code to handle BC. @a8m Your thoughts?
For existing projects, it will no longer allocate a range in the types table. Since the join table never used any autoincrement, there is no information lost.
I am not sure thought, if I oversee something here. The range will stay allocated for existing projects and we cannot remove the allocation since this would result incorrect ranges for every type with a range suceeding the one allocated for any join table.