Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc updates and fixes #249

Merged
merged 4 commits into from
Aug 10, 2019
Merged

Misc updates and fixes #249

merged 4 commits into from
Aug 10, 2019

Conversation

JackNeto
Copy link
Collaborator

@JackNeto JackNeto commented Aug 9, 2019 •
edited
Loading

Summary

  • Updated navigation. Removed the Accounts top nav for now and move it's contents to the Dashboad page
  • Fixed a bug with the initial state load,
  • Fixed opening balance row selection count
  • Fixed transaction display when amount is zero
  • Update transaction rule generation

Screenshot

Screen Shot 2019-08-09 at 11 52 52 AM

Screen Shot 2019-08-09 at 2 23 25 PM

Screen Shot 2019-08-10 at 12 21 52 PM

@coveralls
Copy link

coveralls commented Aug 9, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 305

  • 34 of 40 (85.0%) changed or added relevant lines in 5 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+4.5%) to 76.122%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/core/Dashboard/index.jsx 14 16 87.5%
src/core/Accounts/Transactions/TransactionDialog.jsx 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
src/core/Accounts/Transactions/TransactionsTable.jsx 1 73.29%
Totals Coverage Status
Change from base Build 298: 4.5%
Covered Lines: 1153
Relevant Lines: 1460
💛 - Coveralls

@JackNeto JackNeto changed the title Update nav and fixed initial load Misc updates and fixes Aug 9, 2019
@JackNeto JackNeto merged commit b4db8cb into develop Aug 10, 2019
@JackNeto JackNeto deleted the feature/upate-nav branch August 10, 2019 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JackNeto @coveralls