Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding country; generalizing region and making it optional; #31

Merged
merged 6 commits into from
Apr 24, 2018

Conversation

JackNeto
Copy link
Collaborator

Summary

Generalizing income taxes.
Adding country and optional region

@JackNeto JackNeto added the WIP Work in progress label Apr 22, 2018
@coveralls
Copy link

coveralls commented Apr 22, 2018

Pull Request Test Coverage Report for Build 77

  • 69 of 77 (89.61%) changed or added relevant lines in 6 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+3.9%) to 86.692%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/core/Taxes/index.jsx 6 14 42.86%
Files with Coverage Reduction New Missed Lines %
src/core/Taxes/index.jsx 1 45.0%
Totals Coverage Status
Change from base Build 75: 3.9%
Covered Lines: 188
Relevant Lines: 205

💛 - Coveralls

@JackNeto JackNeto removed the WIP Work in progress label Apr 23, 2018
@JackNeto JackNeto merged commit ac14248 into master Apr 24, 2018
@JackNeto JackNeto deleted the add_tests_to_taxes branch April 24, 2018 17:52
OscillatingMonkey pushed a commit that referenced this pull request Dec 17, 2018
* Adding country; generalizing region and making it optional;

* Organizing the code; Fixed size bug

* More tests

* Added more tests

* Finished tax brakets tests

* More coverage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants