Skip to content

Commit

Permalink
[mob] Change share page copy (#1323)
Browse files Browse the repository at this point in the history
## Description

I thought the "Collect photos" line and the download icon in the share
page looked very confusing:

![old_share_page_copy](https://github.com/ente-io/ente/assets/81471280/cb6a8415-e3a0-403e-abd3-e94b6256a572)

So I changed the icon and copy slightly:

![new_share_page_copy](https://github.com/ente-io/ente/assets/81471280/2480bb43-21fb-487a-af00-c473dbe7439c)


## Tests

Just a copy change, no tests.
  • Loading branch information
vishnukvmd committed Apr 5, 2024
2 parents 360aa29 + 858ba88 commit 5e8f41c
Show file tree
Hide file tree
Showing 26 changed files with 62 additions and 16 deletions.
2 changes: 2 additions & 0 deletions mobile/lib/generated/intl/messages_cs.dart

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions mobile/lib/generated/intl/messages_de.dart

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions mobile/lib/generated/intl/messages_en.dart

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions mobile/lib/generated/intl/messages_es.dart

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions mobile/lib/generated/intl/messages_fr.dart

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions mobile/lib/generated/intl/messages_it.dart

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions mobile/lib/generated/intl/messages_ko.dart

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions mobile/lib/generated/intl/messages_nl.dart

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions mobile/lib/generated/intl/messages_no.dart

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions mobile/lib/generated/intl/messages_pl.dart

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions mobile/lib/generated/intl/messages_pt.dart

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions mobile/lib/generated/intl/messages_zh.dart

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions mobile/lib/generated/l10n.dart

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion mobile/lib/l10n/intl_cs.arb
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,6 @@
"descriptions": "Descriptions",
"addViewers": "{count, plural, zero {Add viewer} one {Add viewer} other {Add viewers}}",
"addCollaborators": "{count, plural, zero {Add collaborator} one {Add collaborator} other {Add collaborators}}",
"longPressAnEmailToVerifyEndToEndEncryption": "Long press an email to verify end to end encryption."
"longPressAnEmailToVerifyEndToEndEncryption": "Long press an email to verify end to end encryption.",
"createCollaborativeLink": "Create collaborative link"
}
3 changes: 2 additions & 1 deletion mobile/lib/l10n/intl_de.arb
Original file line number Diff line number Diff line change
Expand Up @@ -1202,5 +1202,6 @@
"descriptions": "Beschreibungen",
"addViewers": "{count, plural, zero {Add viewer} one {Add viewer} other {Add viewers}}",
"addCollaborators": "{count, plural, zero {Add collaborator} one {Add collaborator} other {Add collaborators}}",
"longPressAnEmailToVerifyEndToEndEncryption": "Long press an email to verify end to end encryption."
"longPressAnEmailToVerifyEndToEndEncryption": "Long press an email to verify end to end encryption.",
"createCollaborativeLink": "Create collaborative link"
}
5 changes: 3 additions & 2 deletions mobile/lib/l10n/intl_en.arb
Original file line number Diff line number Diff line change
Expand Up @@ -1210,5 +1210,6 @@
"invalidEndpoint": "Invalid endpoint",
"invalidEndpointMessage": "Sorry, the endpoint you entered is invalid. Please enter a valid endpoint and try again.",
"endpointUpdatedMessage": "Endpoint updated successfully",
"customEndpoint": "Connected to {endpoint}"
}
"customEndpoint": "Connected to {endpoint}",
"createCollaborativeLink": "Create collaborative link"
}
3 changes: 2 additions & 1 deletion mobile/lib/l10n/intl_es.arb
Original file line number Diff line number Diff line change
Expand Up @@ -978,5 +978,6 @@
"descriptions": "Descriptions",
"addViewers": "{count, plural, zero {Add viewer} one {Add viewer} other {Add viewers}}",
"addCollaborators": "{count, plural, zero {Add collaborator} one {Add collaborator} other {Add collaborators}}",
"longPressAnEmailToVerifyEndToEndEncryption": "Long press an email to verify end to end encryption."
"longPressAnEmailToVerifyEndToEndEncryption": "Long press an email to verify end to end encryption.",
"createCollaborativeLink": "Create collaborative link"
}
3 changes: 2 additions & 1 deletion mobile/lib/l10n/intl_fr.arb
Original file line number Diff line number Diff line change
Expand Up @@ -1159,5 +1159,6 @@
"descriptions": "Descriptions",
"addViewers": "{count, plural, zero {Add viewer} one {Add viewer} other {Add viewers}}",
"addCollaborators": "{count, plural, zero {Add collaborator} one {Add collaborator} other {Add collaborators}}",
"longPressAnEmailToVerifyEndToEndEncryption": "Long press an email to verify end to end encryption."
"longPressAnEmailToVerifyEndToEndEncryption": "Long press an email to verify end to end encryption.",
"createCollaborativeLink": "Create collaborative link"
}
3 changes: 2 additions & 1 deletion mobile/lib/l10n/intl_it.arb
Original file line number Diff line number Diff line change
Expand Up @@ -1121,5 +1121,6 @@
"descriptions": "Descriptions",
"addViewers": "{count, plural, zero {Add viewer} one {Add viewer} other {Add viewers}}",
"addCollaborators": "{count, plural, zero {Add collaborator} one {Add collaborator} other {Add collaborators}}",
"longPressAnEmailToVerifyEndToEndEncryption": "Long press an email to verify end to end encryption."
"longPressAnEmailToVerifyEndToEndEncryption": "Long press an email to verify end to end encryption.",
"createCollaborativeLink": "Create collaborative link"
}
3 changes: 2 additions & 1 deletion mobile/lib/l10n/intl_ko.arb
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,6 @@
"descriptions": "Descriptions",
"addViewers": "{count, plural, zero {Add viewer} one {Add viewer} other {Add viewers}}",
"addCollaborators": "{count, plural, zero {Add collaborator} one {Add collaborator} other {Add collaborators}}",
"longPressAnEmailToVerifyEndToEndEncryption": "Long press an email to verify end to end encryption."
"longPressAnEmailToVerifyEndToEndEncryption": "Long press an email to verify end to end encryption.",
"createCollaborativeLink": "Create collaborative link"
}
3 changes: 2 additions & 1 deletion mobile/lib/l10n/intl_nl.arb
Original file line number Diff line number Diff line change
Expand Up @@ -1197,5 +1197,6 @@
"descriptions": "Descriptions",
"addViewers": "{count, plural, zero {Add viewer} one {Add viewer} other {Add viewers}}",
"addCollaborators": "{count, plural, zero {Add collaborator} one {Add collaborator} other {Add collaborators}}",
"longPressAnEmailToVerifyEndToEndEncryption": "Long press an email to verify end to end encryption."
"longPressAnEmailToVerifyEndToEndEncryption": "Long press an email to verify end to end encryption.",
"createCollaborativeLink": "Create collaborative link"
}
3 changes: 2 additions & 1 deletion mobile/lib/l10n/intl_no.arb
Original file line number Diff line number Diff line change
Expand Up @@ -30,5 +30,6 @@
"descriptions": "Descriptions",
"addViewers": "{count, plural, zero {Add viewer} one {Add viewer} other {Add viewers}}",
"addCollaborators": "{count, plural, zero {Add collaborator} one {Add collaborator} other {Add collaborators}}",
"longPressAnEmailToVerifyEndToEndEncryption": "Long press an email to verify end to end encryption."
"longPressAnEmailToVerifyEndToEndEncryption": "Long press an email to verify end to end encryption.",
"createCollaborativeLink": "Create collaborative link"
}
3 changes: 2 additions & 1 deletion mobile/lib/l10n/intl_pl.arb
Original file line number Diff line number Diff line change
Expand Up @@ -117,5 +117,6 @@
"descriptions": "Descriptions",
"addViewers": "{count, plural, zero {Add viewer} one {Add viewer} other {Add viewers}}",
"addCollaborators": "{count, plural, zero {Add collaborator} one {Add collaborator} other {Add collaborators}}",
"longPressAnEmailToVerifyEndToEndEncryption": "Long press an email to verify end to end encryption."
"longPressAnEmailToVerifyEndToEndEncryption": "Long press an email to verify end to end encryption.",
"createCollaborativeLink": "Create collaborative link"
}
3 changes: 2 additions & 1 deletion mobile/lib/l10n/intl_pt.arb
Original file line number Diff line number Diff line change
Expand Up @@ -1203,5 +1203,6 @@
"descriptions": "Descrições",
"addViewers": "{count, plural, zero {Adicionar visualizador} one {Adicionar visualizador} other {Adicionar Visualizadores}}",
"addCollaborators": "{count, plural, zero {Adicionar colaborador} one {Adicionar coloborador} other {Adicionar colaboradores}}",
"longPressAnEmailToVerifyEndToEndEncryption": "Pressione e segure um e-mail para verificar a criptografia de ponta a ponta."
"longPressAnEmailToVerifyEndToEndEncryption": "Pressione e segure um e-mail para verificar a criptografia de ponta a ponta.",
"createCollaborativeLink": "Create collaborative link"
}
3 changes: 2 additions & 1 deletion mobile/lib/l10n/intl_zh.arb
Original file line number Diff line number Diff line change
Expand Up @@ -1203,5 +1203,6 @@
"descriptions": "描述",
"addViewers": "{count, plural, zero {添加查看者} one {添加查看者} other {添加查看者}}",
"addCollaborators": "{count, plural, zero {添加协作者} one {添加协作者} other {添加协作者}}",
"longPressAnEmailToVerifyEndToEndEncryption": "长按电子邮件以验证端到端加密。"
"longPressAnEmailToVerifyEndToEndEncryption": "长按电子邮件以验证端到端加密。",
"createCollaborativeLink": "Create collaborative link"
}
6 changes: 3 additions & 3 deletions mobile/lib/ui/sharing/share_collection_page.dart
Original file line number Diff line number Diff line change
Expand Up @@ -260,15 +260,15 @@ class _ShareCollectionPageState extends State<ShareCollectionPage> {
height: 24,
),
MenuSectionTitle(
title: S.of(context).collaborativeLink,
title: S.of(context).collectPhotos,
iconData: Icons.public,
),
MenuItemWidget(
captionedTextWidget: CaptionedTextWidget(
title: S.of(context).collectPhotos,
title: S.of(context).createCollaborativeLink,
makeTextBold: true,
),
leadingIcon: Icons.download_sharp,
leadingIcon: Icons.people_alt_outlined,
menuItemColor: getEnteColorScheme(context).fillFaint,
showOnlyLoadingState: true,
onTap: () async {
Expand Down

0 comments on commit 5e8f41c

Please sign in to comment.