Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fastlane location #1172

Open
licaon-kter opened this issue Mar 21, 2024 · 6 comments
Open

Fastlane location #1172

licaon-kter opened this issue Mar 21, 2024 · 6 comments
Assignees
Labels
- auth Relates to Ente Auth - photos Relates to the Ente Photos --mobile Platform is mobile

Comments

@licaon-kter
Copy link

Description

should be in root of repo maybe https://gitlab.com/-/snippets/1895688#locations

ref: https://f-droid.org/packages/io.ente.auth/

ref: https://f-droid.org/packages/io.ente.photos.fdroid/

or maybe Triple-T is better for more apps in the same repo situation: https://gitlab.com/-/snippets/1901490

Version

No response

What product are you using?

No response

What platform are you using?

No response

@vishnukvmd vishnukvmd added --mobile Platform is mobile - auth Relates to Ente Auth - photos Relates to the Ente Photos and removed triage labels Mar 26, 2024
@vishnukvmd vishnukvmd self-assigned this Mar 26, 2024
@vishnukvmd
Copy link
Member

Thanks for the info @licaon-kter, Triple-T does seem like the way forward.

Could you please confirm that the paths will be relative to the project?

For example, would placing the full-description.txts in the following directories achieve the desired outcome for our 2 apps?

  • auth/android/app/src/main/play/listings/en-US/full-description.txt
  • mobile/android/app/src/main/play/listings/en-US/full-description.txt

If it'll help, I'd be happy to put these files in place and trigger a test-build.

@licaon-kter
Copy link
Author

From my local tests it appears to not be picked up :(

@linsui can you decode if https://gitlab.com/fdroid/fdroidserver/-/blob/master/fdroidserver/update.py#L933 should pickup https://github.com/ente-io/ente/blob/main/auth/android/app/src/main/play/listings/en-US/full_description.txt ?

subdir is only auth an we don't use a gradle flavor in recipe 🤷

@linsui
Copy link

linsui commented Apr 9, 2024

* can only match one segment so I thought it doesn't work. That's why we have to add a special check for flutter in https://gitlab.com/fdroid/fdroidserver/-/blob/master/fdroidserver/update.py#L957.

@linsui
Copy link

linsui commented Apr 9, 2024

I thought we can use auth/android as subdir. We need to build flutter app manually anyway.

@vishnukvmd
Copy link
Member

@linsui just to be sure, as you proposing that we place the file under auth/android/listings/en-US/full-description.txt?

Thank you!

@linsui
Copy link

linsui commented Apr 10, 2024

No, I meant that we can tweak the metadata. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
- auth Relates to Ente Auth - photos Relates to the Ente Photos --mobile Platform is mobile
Projects
None yet
Development

No branches or pull requests

3 participants