Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Auth] Allow for configuring a custom server #726

Merged
merged 12 commits into from Mar 7, 2024
Merged

Conversation

vishnukvmd
Copy link
Member

Description

Users can now tap on the onboarding screen 7 times to bring up a page where they can configure the endpoint the app should be connecting to.

self-host

Tests

  • Verified that production flows are working as expected
  • Verified that configuring the endpoint to a local instance lets you
    • Connect to that instance
    • Create an account
    • Add a key
    • Modify a key
    • Logout and log back in

@vishnukvmd vishnukvmd requested a review from ua741 March 6, 2024 15:09
@ua741
Copy link
Member

ua741 commented Mar 6, 2024

Should we show the server url on UI when it's not the production endpoint (https://api.ente.io)

As this url will be cleared on logout, it will be probably helpful when it's shown during login/sign up and may be the in hamburger menu below version.

@ua741 ua741 disabled auto-merge March 7, 2024 00:34
@vishnukvmd
Copy link
Member Author

Should we show the server url on UI when it's not the production endpoint (https://api.ente.io)

As this url will be cleared on logout, it will be probably helpful when it's shown during login/sign up and may be the in hamburger menu below version.

Done. Have also added a check to /ping to verify the endpoint.

@vishnukvmd vishnukvmd merged commit 90bbc54 into main Mar 7, 2024
2 checks passed
@vishnukvmd vishnukvmd deleted the auth_selfhost branch March 7, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants