Skip to content
This repository has been archived by the owner on May 14, 2024. It is now read-only.

Fix export issues #1007

Merged
merged 10 commits into from
Apr 4, 2023
Merged

Fix export issues #1007

merged 10 commits into from
Apr 4, 2023

Conversation

abhinavkgrd
Copy link
Member

@abhinavkgrd abhinavkgrd commented Mar 31, 2023 •
edited
Loading

Description

  • fix multiple continuous export attempt handling
  • fixed page change breaking export
  • refactored some UI logic
  • updated progress UI to increase the progress bar for failed files but not increase the exported count

Test Plan

  • tested export and continuous export with new code
  • tested page change fix
  • verified the UI change
  • asked jishnu to confirm the fixes

@abhinavkgrd abhinavkgrd marked this pull request as ready for review April 3, 2023 05:14
@abhinavkgrd abhinavkgrd marked this pull request as draft April 3, 2023 05:14
@abhinavkgrd abhinavkgrd marked this pull request as ready for review April 3, 2023 10:33
@cloudflare-pages
Copy link

cloudflare-pages bot commented Apr 3, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 06b3dea
Status: ✅  Deploy successful!
Preview URL: https://4e874d0b.bada-frame.pages.dev
Branch Preview URL: https://fix-export-issues.bada-frame.pages.dev

View logs

@abhinavkgrd abhinavkgrd requested a review from ua741 April 3, 2023 12:12
@abhinavkgrd abhinavkgrd merged commit 05880a3 into main Apr 4, 2023
@abhinavkgrd abhinavkgrd deleted the fix-export-issues branch April 4, 2023 07:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ua741 ua741 ua741 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@abhinavkgrd @ua741