Skip to content
This repository has been archived by the owner on May 14, 2024. It is now read-only.

Fix ffmpeg related issue #1029

Merged
merged 6 commits into from
Apr 8, 2023
Merged

Fix ffmpeg related issue #1029

merged 6 commits into from
Apr 8, 2023

Conversation

abhinavkgrd
Copy link
Member

@abhinavkgrd abhinavkgrd commented Apr 8, 2023 •
edited
Loading

Description

  • fixed race condition in getInstance call causing multiple FFmpeg workers to be generated leading to tab crash
  • changed thumbnail generation timestamps attempts to 1st video sec and 0th video second.

Test Plan

  • tested the changes
  • ran sample dataset upload test

@abhinavkgrd abhinavkgrd marked this pull request as draft April 8, 2023 07:39
@abhinavkgrd abhinavkgrd marked this pull request as ready for review April 8, 2023 07:48
@cloudflare-pages
Copy link

cloudflare-pages bot commented Apr 8, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 15ab880
Status: ✅  Deploy successful!
Preview URL: https://ddc09a84.bada-frame.pages.dev
Branch Preview URL: https://fix-multiple-ffmpeg-spawn-is.bada-frame.pages.dev

View logs

@abhinavkgrd abhinavkgrd requested a review from ua741 April 8, 2023 07:51
@abhinavkgrd abhinavkgrd merged commit b666012 into main Apr 8, 2023
@abhinavkgrd abhinavkgrd deleted the fix-multiple-ffmpeg-spawn-issue branch April 8, 2023 08:09
@abhinavkgrd abhinavkgrd mentioned this pull request Apr 8, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ua741 ua741 ua741 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@abhinavkgrd @ua741