Skip to content
This repository has been archived by the owner on May 14, 2024. It is now read-only.

Fix exif date parsing #1038

Merged
merged 8 commits into from
Apr 12, 2023
Merged

Fix exif date parsing #1038

merged 8 commits into from
Apr 12, 2023

Conversation

abhinavkgrd
Copy link
Member

@abhinavkgrd abhinavkgrd commented Apr 11, 2023

Description

  • disabled inbuilt EXIF parsing and added a custom parser to handle EXIF DateTime value with some random character in the dateTimeString. 2014:08:25 18:33:21\u0000\u001d
  • handled UTC offset if present on the date
  • when no UTC offset is provided the date is considered to be in UTC time

Test Plan

tested with sample dataset files.
tested with sample dates

  • random characters in between ("2014:08:s25 s18:s33:ss21\u0000\u001d")
  • with UTC offset "2010:07:06 20:45:12+06:00"

@cloudflare-pages
Copy link

cloudflare-pages bot commented Apr 11, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 80ddf40
Status: ✅  Deploy successful!
Preview URL: https://173a0c7e.bada-frame.pages.dev
Branch Preview URL: https://fix-exif-date-parsing.bada-frame.pages.dev

View logs

@abhinavkgrd abhinavkgrd marked this pull request as ready for review April 11, 2023 14:13
@abhinavkgrd abhinavkgrd requested a review from ua741 April 11, 2023 14:15
@abhinavkgrd abhinavkgrd merged commit 688b28e into main Apr 12, 2023
@abhinavkgrd abhinavkgrd deleted the fix-exif-date-parsing branch April 12, 2023 03:34
@abhinavkgrd abhinavkgrd mentioned this pull request Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants