This repository has been archived by the owner on May 14, 2024. It is now read-only.
Switch to prettier defaults #1656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is unfortunately a huge diff, but now is as good as ever to do this pending chore. - Move to prettier (v3) defaults. The only thing we tweak is the tabWidth (the default is 2, we change it to 4). - Use the prettier plugin to sort imports. We were not changing the defaults of prettier much anyway, the main thing that has changed is the switching from the overridden single quotes to the default double quotes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is unfortunately a huge diff, but now is as good as ever to do this pending chore.
Move to prettier (v3) defaults. The only thing we tweak is the tabWidth (the default is 2, we change it to 4).
Use the prettier plugin to sort imports.
We were not changing the defaults of prettier much anyway, the main thing that has changed is the switching from the overridden single quotes to the default double quotes.
Note: I did not manually change any lines of code, this is all done by
yarn prettier --write .The only manual change I made was moving all the new .prettierrc.json files to the top level.