Skip to content
This repository has been archived by the owner on May 14, 2024. It is now read-only.

Empty state #946

Merged
merged 25 commits into from
Feb 23, 2023
Merged

Empty state #946

merged 25 commits into from
Feb 23, 2023

Conversation

Ananddubey01
Copy link
Contributor

@Ananddubey01 Ananddubey01 commented Feb 13, 2023

Description

  • Change Empty state UI
  • Added Empty state for instances of only incoming share

Test Plan

Screenshot from 2023-02-21 13-36-01

@cloudflare-pages
Copy link

cloudflare-pages bot commented Feb 13, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 384545a
Status: ✅  Deploy successful!
Preview URL: https://6fec3829.bada-frame.pages.dev
Branch Preview URL: https://empty-state.bada-frame.pages.dev

View logs

src/components/EmptyScreen.tsx Outdated Show resolved Hide resolved
src/components/EmptyScreen.tsx Outdated Show resolved Hide resolved
src/components/PhotoFrame.tsx Outdated Show resolved Hide resolved
src/components/EmptyScreen.tsx Outdated Show resolved Hide resolved
@abhinavkgrd
Copy link
Member

also can please update the screenshots too

@CLAassistant
Copy link

CLAassistant commented Feb 17, 2023

CLA assistant check
All committers have signed the CLA.

@abhinavkgrd
Copy link
Member

can you confirm the ente-duck.png and ente-duck@2x.png are not the same, they have the same dimension.
is it expected?

@abhinavkgrd
Copy link
Member

public/images/download_assets/download_fdroid@3x.png is a github logo not fdroid

@vishnukvmd
Copy link
Member

public/images/download_assets/download_fdroid@3x.png is a github logo not fdroid

Hey, let's remove the section that contains the links to mobile apps. It feels noisy, and as a user I'm not sure user what the call-to-action here is. All we want the user to do at this point is upload a file. On uploading a file, they anyway get an email notifying about the existence of our mobile app.

I've updated Figma to reflect this.

Sorry about this @Ananddubey01! 🙏

Screenshot 2023-02-22 at 4 58 09 PM

@vishnukvmd
Copy link
Member

Two nits:

  1. ente should be using our brand font (Montserrat)
  2. On Figma there's a vertical spacing of 8px between "Welcome to ente" and the next line. That seems to be missing here.

@abhinavkgrd abhinavkgrd merged commit 8bcacda into main Feb 23, 2023
@abhinavkgrd abhinavkgrd deleted the empty-state branch February 23, 2023 07:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants