Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PendingReview.php #113

Merged
merged 1 commit into from Apr 26, 2022
Merged

Update PendingReview.php #113

merged 1 commit into from Apr 26, 2022

Conversation

revansx
Copy link
Contributor

@revansx revansx commented Apr 24, 2020

required to process certain pages based on MW use of new "actor" table

required to process certain pages based on MW use of new "actor" table
@jamesmontalvo3
Copy link
Contributor

I haven't seen this cause an issue yet. Can you provide more info?

@revansx
Copy link
Contributor Author

revansx commented Jun 12, 2020

I believe it is in regards to the actor migration. All I know is that I had errors when I clicked on my "Pending Reviews" in my wikis after I upgraded to 34.x and this was one of the changes I needed to implement to fix it. Does that help?

@jamesmontalvo3
Copy link
Contributor

Okay. I haven't used WatchAnalytics yet on a live server running 1.34, only on dev servers. Thanks for the additional info.

@olsonjaredm
Copy link

olsonjaredm commented Apr 26, 2022

Hey guys! I can confirm this error and that this is the correct fix for compatibility with MW 1.34+.
When loading the Pending Reviews page, the extension looks to see if there are any deleted pages to display to the user (function getDeletionLog). If there are, it looks for the fields logging.log_user and logging.log_user_text.

This gave us a database error Error 1054: Unknown column 'l.log_user' in 'field list' because these were not present in our MW 1.35.5 DB table. They were removed in MW 1.34 (https://www.mediawiki.org/wiki/Manual:Logging_table#log_user) in favor of log_actor.

Copy link

@olsonjaredm olsonjaredm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified fix on 1.35.5.

@jamesmontalvo3 jamesmontalvo3 merged commit adf3421 into enterprisemediawiki:master Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants