Skip to content

Commit

Permalink
Merge pull request #394 from enthought/fix/chain
Browse files Browse the repository at this point in the history
BUG: Fix use of itertools.chain()
  • Loading branch information
rkern committed Dec 18, 2017
2 parents 5f2fb39 + 8f59ecc commit d0790a5
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 2 deletions.
2 changes: 1 addition & 1 deletion chaco/plot.py
Expand Up @@ -1276,7 +1276,7 @@ def _handle_range_changed(self, name, old, new):
if new is not None:
new.add(datasource)
range_name = name + "_range"
for renderer in itertools.chain(six.itervalues(self.plots)):
for renderer in itertools.chain(*six.itervalues(self.plots)):
if hasattr(renderer, range_name):
setattr(renderer, range_name, new)

Expand Down
15 changes: 14 additions & 1 deletion chaco/tests/plot_test_case.py
Expand Up @@ -3,7 +3,7 @@
from numpy import arange

# Chaco imports
from chaco.api import ArrayPlotData, Plot
from chaco.api import ArrayPlotData, Plot, DataRange1D


class PlotTestCase(unittest.TestCase):
Expand All @@ -18,5 +18,18 @@ def test_plot_from_unsupported_array_shape(self):
data.update_data(x=arr, y=arr)
self.assertRaises(ValueError, plot.plot, ("x", "y"))

def test_range_change(self):
arr = arange(10)
data = ArrayPlotData(x=arr, y=arr)
plot = Plot(data)
renderer = plot.plot(('x', 'y'))[0]
new_range = DataRange1D()
old_range = plot.index_range
self.assertIsNot(old_range, new_range)
self.assertIs(renderer.index_range, old_range)
plot.index_range = new_range
self.assertIs(plot.index_range, new_range)
self.assertIs(renderer.index_range, new_range)

if __name__ == "__main__":
unittest.main()

0 comments on commit d0790a5

Please sign in to comment.