Fix PDF clipping and add an add_page() method. #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Hi John. I just changed my code to stop using a 'priming' plot to test the modified add_page(). It appears that add_page() now duplicates the behavior of the ReportLab function. As far as I can tell, everything is functioning correctly. Thanks! |
|
I've found that this change works well for me, and I haven't encountered any broken examples with it merged into my own master. Is there anything outstanding that is preventing it from being merged? |
|
Nope. |
jwiggins
added a commit
that referenced
this pull request
May 21, 2013
Fix PDF clipping and add an add_page() method.
|
Thanks for testing @jilott |
|
My pleasure, thanks for implementing @jwiggins . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on feedback from @jilott, fix the clipping that is done when drawing to a
PdfGraphicsContextso that it doesn't discard a plot's padding (which is generally where axis components draw).This also adds an
add_page()method that starts a new page in the PDF document and makes sure that it gets the same origin offset as the first page did.