Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old unnecessary SkipTest #190

Merged
merged 2 commits into from
Apr 15, 2014
Merged

Remove old unnecessary SkipTest #190

merged 2 commits into from
Apr 15, 2014

Conversation

kjordahl
Copy link
Contributor

Removes an old SkipTest for a test that doesn't no longer fails (ref: https://svn.enthought.com/enthought/ticket/1618).

Cherry-picked from #189.

@enbuilder
Copy link

Merged build triggered. Test FAILed.

@enbuilder
Copy link

Merged build started. Test FAILed.

@cfarrow
Copy link
Member

cfarrow commented Apr 15, 2014

LGTM

@enbuilder
Copy link

Merged build finished. Test FAILed.

@enbuilder
Copy link

Test FAILed.
Refer to this link for build results: http://jenkins.enthought.com:8080/job/Chaco_PR_builder/27/

Build Log
last 5 lines

[...truncated 13 lines...]
x86_64,Windows completed with result FAILURE
x86,Windows completed with result FAILURE
x86_64,Linux completed with result UNSTABLE
x86,Linux completed with result UNSTABLE

@cfarrow
Copy link
Member

cfarrow commented Apr 15, 2014

I take back the LGTM. Please update CHANGES.txt.

@enbuilder
Copy link

Merged build triggered. Test FAILed.

@enbuilder
Copy link

Merged build started. Test FAILed.

@kjordahl
Copy link
Contributor Author

@cfarrow Done, but this seems like a pretty minor, non-user-facing change. I'm not sure what the standard for including in the changelog is. There are a few other testing-related PRs merged recently, perhaps they can be mentioned in a single line in CHANGES.txt (and of course testing needs a lot more work).

@cfarrow
Copy link
Member

cfarrow commented Apr 15, 2014

Thanks.

It does seem like a minor issue, but I'm not sure where to draw that line. I see no problem with merging all testing-related PRs on a single line, however.

LGTM (for real).

cfarrow added a commit that referenced this pull request Apr 15, 2014
@cfarrow cfarrow merged commit c5af188 into master Apr 15, 2014
@cfarrow cfarrow deleted the test/remove-skiptest branch April 15, 2014 21:11
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling f953b2a on test/remove-skiptest into 94dd348 on master.

@enbuilder
Copy link

Merged build finished. Test FAILed.

@enbuilder
Copy link

Test FAILed.
Refer to this link for build results: http://jenkins.enthought.com:8080/job/Chaco_PR_builder/28/

Build Log
last 5 lines

[...truncated 18 lines...]
x86_64,Linux appears to be cancelled
x86_64,Linux completed with result ABORTED
Aborted
Aborted by anonymous

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants