New Perceptual Colormaps #204
Conversation
|
|
||
|
|
||
| # XYZ white-point coordinates | ||
| # from http://www.aim-dtp.net/aim/technology/cie_xyz/cie_xyz.htm |
There was a problem hiding this comment.
This is an ad site now. The referenced page is in the web archive.
https://web.archive.org/web/20080705052651/http://www.aim-dtp.net/aim/technology/cie_xyz/cie_xyz.htm
|
The content is good and worth keeping. However, I don't think chaco is the best home for the supporting code. This code is widely usable, vetted at some level since it came from scipy, and should probably be made into its own package. Some of this is already in scikit-image. I don't necessarily want chaco to depend on scikit image, but I'd also like to avoid taking on lots of new specialized code. |
|
I can pare down the colorspace stuff that isn't used, but I'm opposed to adding a dependency. |
|
Merged build triggered. |
|
Merged build started. |
|
Alternately, I can add my colorblindness-simulating meta- |
|
Adding new colormaps defeats the YAGNI argument for the supporting code. (I don't think YAGNI applies to colormaps until they become visually indistinct.) +1 Dependence on scikit-image is off the table. If creating a new package (scikit-color?) is out of the question, then we need to test the new colormaps. I'm less worried about correctness than code breaking with numpy 1.9 or python 3 (eventually). Some high level tests that instantiate the new colormaps and verifies any meaningful metrics should suffice. |
|
Merged build finished. |
|
@rkern please also note the drastic decrease in test coverage. |
|
Noted, but it appears unrelated to the changes here. |
|
Yes we have had that +/-10% oscillation for a while. I need to find some time to look into this... |
|
Merged build triggered. |
|
Merged build started. |
|
Merged build finished. |
|
LGTM. Thanks. |
I have added a few perceptually-based colormaps from various sources.