Use set_bounds rather than setting low and high individually for Zoom.
#233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| x_mapper.range.high = self.next[1] | ||
| y_mapper.range.low = self.next[2] | ||
| y_mapper.range.high = self.next[3] | ||
| x_mapper.range.set_bound(low=self.next[0], high=self.next[1]) |
There was a problem hiding this comment.
Uhm yes! Sorry, I thought I had tested it but it looks like I don't know how to trigger this.
|
Are there any tests that cover this refactoring? |
|
If you are doing this, it may be worth looking for places where the mapper high and low are set individually as well, eg. https://github.com/enthought/chaco/blob/master/chaco/data_view.py#L306 I had considered fixing those in an earlier PR, but it seemed tangential. |
|
The example you give is changing a |
|
It has a |
|
Got it |
corranwebster
added a commit
that referenced
this pull request
Jan 22, 2016
Use `set_bounds` rather than setting `low` and `high` individually for Zoom.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the number of event fired around drastically.
Compare this profile snapshot before the change:
and after:
Notice that the time per-call of
_do_zoomis reduced from0.00209to0.00122, but especially that_set_low_settingand_set_high_settingare called once perzoom_in/zoom_out, reducing the potential for trouble if anything depends on the bounds of the plot.