fix gc undeclare #883
Merged
fix gc undeclare #883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corranwebster
suggested changes
Apr 6, 2023
chaco/plots/polar_line_renderer.py
Outdated
| @@ -133,6 +133,7 @@ def _downsample(self): | |||
| def _draw_plot(self, *args, **kw): | |||
| """Draws the 'plot' layer.""" | |||
| self._gather_points() | |||
| gc = args[0] | |||
There was a problem hiding this comment.
If you want the gc to be the first argument to the function, make it the first argument to the function!
Doing this is fragile, not self-documenting and will produce confusing error messages if used incorrectly.
corranwebster
approved these changes
Apr 6, 2023
|
For reference, the prototype of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found that the gc (GraphicsContext) is referenced before construction in the line 136. This has caused the test chaco/chaco/examples/demo/simple_polar.py to fail.
The solution is to find the gc in the context. A gc context is actually conveniently included in the *args, thus retrieving that gc as GraphicContext to solve the problem. closes #875