Adding aspect ratio support for ZoomTool's box selection mode #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. |
rkern
added a commit
that referenced
this pull request
Feb 7, 2013
Adding aspect ratio support for ZoomTool's box selection mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the user request on the enthought-dev mailing list:
https://mail.enthought.com/pipermail/enthought-dev/2013-January/031979.html
It's easy to test this by modifying almost any of the examples that use ZoomTool, and just adding e.g. "aspect_ratio=1.5" to the ZoomTool constructor. Tested with positive, negative, and zero aspect ratio.