Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Python311 to environment matrix of appveyor.yml #361

Merged
merged 1 commit into from Nov 8, 2022
Merged

add Python311 to environment matrix of appveyor.yml #361

merged 1 commit into from Nov 8, 2022

Conversation

junkmd
Copy link
Collaborator

@junkmd junkmd commented Oct 25, 2022 •
edited

Appveyor will be start to support stable Python 3.11(appveyor/ci#3844).

Let's add it to ci's environment matrix.

I will open this PR when Appveyor started to support Py311.

@vasily-v-ryabov vasily-v-ryabov marked this pull request as ready for review November 7, 2022 14:21
vasily-v-ryabov
vasily-v-ryabov approved these changes Nov 7, 2022
View reviewed changes
Copy link
Collaborator

@vasily-v-ryabov vasily-v-ryabov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python 3.11.0 has been added to AppVeyor according to their docs: https://www.appveyor.com/docs/windows-images-software/#python

@vasily-v-ryabov
Copy link
Collaborator

vasily-v-ryabov commented Nov 7, 2022 •
edited

Please rebase this PR to restart the CI. I have no access to comtypes' AppVeyor project to restart it manually.

@junkmd
Copy link
Collaborator Author

junkmd commented Nov 7, 2022

Ok, I rebased this PR.

@junkmd
Copy link
Collaborator Author

junkmd commented Nov 7, 2022

Oh, It's failed... 😭

We will probably have to wait until it is officially announced at https://www.appveyor.com/updates/

Since Visual Studio 2019 has been announced as being supported, Visual Studio 2022 will probably be supported as well, not too late.

@junkmd
Copy link
Collaborator Author

junkmd commented Nov 7, 2022

I woke up this morning to find that support for Visual Studio 2022 had been announced at https://www.appveyor.com/updates/2022/11/07/.

I immediately rebased this PR and restarted AppVeyor CI and it worked! 😄

@vasily-v-ryabov vasily-v-ryabov merged commit 26ad993 into enthought:master Nov 8, 2022
@junkmd junkmd deleted the add_py311_to_appveyor branch November 8, 2022 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vasily-v-ryabov vasily-v-ryabov vasily-v-ryabov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@junkmd @vasily-v-ryabov