Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make generating ...property DRY. #368

Merged

Conversation

junkmd
Copy link
Collaborator

@junkmd junkmd commented Nov 3, 2022

As mentioned in #367, I changed to reference attributes of _MemberSpec instead of unpacking it.

Adding type annotations to _make_methods or _make_methods argument(methods in line 650) will cause errors in the static type checker.
Because methods variables are overwritten(methods in line 770) in the function.
image

To solve this, I planned to assign them to different named variables.
However, the same process was used where the type checker error raised.
Therefore I separated the process into PropertyMapping class, made variables not overwritten and made the class called from both methods.

junkmd added a commit to junkmd/pywinauto that referenced this pull request Nov 3, 2022
vasily-v-ryabov added a commit to vasily-v-ryabov/pywinauto that referenced this pull request Nov 7, 2022
@vasily-v-ryabov vasily-v-ryabov merged commit c97c582 into enthought:master Nov 7, 2022
@junkmd junkmd deleted the make_generating_property_DRY branch November 7, 2022 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants