Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #367, I changed to reference attributes of
_MemberSpec
instead of unpacking it.Adding type annotations to
_make_methods
or_make_methods
argument(methods
in line 650) will cause errors in the static type checker.Because
methods
variables are overwritten(methods
in line 770) in the function.To solve this, I planned to assign them to different named variables.
However, the same process was used where the type checker error raised.
Therefore I separated the process into
PropertyMapping
class, made variables not overwritten and made the class called from both methods.