Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #436. #478

Merged
merged 2 commits into from
Jul 1, 2014
Merged

Fixes #436. #478

merged 2 commits into from
Jul 1, 2014

Conversation

kwmsmith
Copy link
Contributor

local_from_global() and global_from_local() now take sequences
rather than *args.

Also removed an unused method on GlobalIndex and made a related
GlobalIndex method internal.

Fixes #436.
a5a0bdd 
`local_from_global()` and `global_from_local()` now take sequences
rather than *args.

Also removed an unused method on `GlobalIndex` and made a related
`GlobalIndex` method internal.
@kwmsmith kwmsmith added the bug label Jun 30, 2014
@kwmsmith kwmsmith added this to the 0.4 milestone Jun 30, 2014
bgrant
bgrant reviewed Jul 1, 2014
View reviewed changes
distarray/local/localarray.py

def get_slice(self, global_inds, new_distribution):
try:
local_inds = self.global_to_local(*global_inds)
local_inds = self._global_to_local(global_inds)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this method be renamed to _local_from_global?

@bgrant
Copy link
Contributor

bgrant commented Jul 1, 2014

Fine by me. I'll merge after Travis.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.87%) when pulling 7935548 on bugfix/436 into 7817b64 on master.

bgrant added a commit that referenced this pull request Jul 1, 2014
@bgrant
Merge pull request #478 from enthought/bugfix/436
ebb5f3b 
Fixes #436.
@bgrant bgrant merged commit ebb5f3b into master Jul 1, 2014
@bgrant bgrant deleted the bugfix/436 branch July 1, 2014 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bgrant bgrant

Labels
bug
Projects
None yet
Milestone
0.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kwmsmith @bgrant @coveralls