Add an action that builds wheels #1039
Conversation
This will eventually be folded into the release action.
| ], | ||
| }, | ||
| zip_safe=False, | ||
| python_requires=">=3.7", |
There was a problem hiding this comment.
This is the only change here apart from formatting.
| with: | ||
| python-version: '3.8' | ||
| python-version: '3.11' |
There was a problem hiding this comment.
Any reason why the sdist should be created with the latest possible version of Python? I would assume an older version was better (and Cython source would be compiled by the user of the sdist)
There was a problem hiding this comment.
No particular reason other than the assumption that most recent python would automatically get the most current packaging infrastructure. Cython shouldn't be an issue because I don't think we ship the generated .cpp files in the sdist any more.
There was a problem hiding this comment.
Looks like I was wrong about that:
Line 17 in 2230bb4
Probably should remove that - the isolated builds should install Cython correctly from the info in the sdist if needed when building.
Edit: Nope, that's all in the agg subdirectory.
And I also spot a stray gl reference in the manifest as well.
This adds a stand-alone build wheel action, and then adds it to the publish to PyPI action for releases. This builds wheels for Mac, Windows and Linux Intel architecture, as well as Linux ARM.
It doesn't handle Mac ARM or Universal, but it potentially could with some more work and testing.