Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add assert methods for drawing and compiled paths #123

Merged
merged 14 commits into from Mar 3, 2014

Conversation

itziakos
Copy link
Member

This PR adds a couple of assert methods in enable test assistant to help test path creation and drawing methods.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling dc34da1 on enh-path-assertion-methods into f618921 on master.

@@ -89,6 +89,13 @@ def create_mock_window(self):
window.control.set_pointer = Mock()
return window

def create_a_mock_gc(self, width, height):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest naming this create_mock_gc, for consistency with create_mock_window.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Or perhaps even create_mock_graphics_context, though gc seems sufficiently clear in this context.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will go with create_mock_gc

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@itziakos
Copy link
Member Author

I need to add a few tests using the new assert methods.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling c0b8e2e on enh-path-assertion-methods into f618921 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.48%) when pulling 34b0e34 on enh-path-assertion-methods into f618921 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 272c4b9 on enh-path-assertion-methods into f618921 on master.

@itziakos
Copy link
Member Author

@jwiggins and @mdickinson, I have updated the PR. Please have another look and let me know if I have missed anything.

note: I have factored out the graphic context assert methods into the kiva subpackage where I think they belong.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 7b12d9a on enh-path-assertion-methods into f618921 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 7b12d9a on enh-path-assertion-methods into f618921 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) when pulling 4761ec7 on enh-path-assertion-methods into f618921 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 6252681 on enh-path-assertion-methods into f618921 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 6252681 on enh-path-assertion-methods into f618921 on master.

@jwiggins
Copy link
Member

jwiggins commented Mar 3, 2014

LGTM

jwiggins added a commit that referenced this pull request Mar 3, 2014
Add assert methods for drawing and compiled paths
@jwiggins jwiggins merged commit a5b8cb9 into master Mar 3, 2014
@jwiggins jwiggins deleted the enh-path-assertion-methods branch March 3, 2014 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants