New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add assert methods for drawing and compiled paths #123
Conversation
@@ -89,6 +89,13 @@ def create_mock_window(self): | |||
window.control.set_pointer = Mock() | |||
return window | |||
|
|||
def create_a_mock_gc(self, width, height): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest naming this create_mock_gc
, for consistency with create_mock_window
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Or perhaps even create_mock_graphics_context
, though gc
seems sufficiently clear in this context.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will go with create_mock_gc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
I need to add a few tests using the new assert methods. |
@jwiggins and @mdickinson, I have updated the PR. Please have another look and let me know if I have missed anything. note: I have factored out the graphic context assert methods into the kiva subpackage where I think they belong. |
LGTM |
Add assert methods for drawing and compiled paths
This PR adds a couple of assert methods in enable test assistant to help test path creation and drawing methods.