Color Transfer Function editor gadget

[jwiggins]

This big chunk of code implements a CTF editor for creating/editing functions which map from some data space to RGBA values. I'm using it for a volume rendering viewer, but it could also be used for creating a colormap for an image plot.

NOTE: This code needs needs traits-enaml [1] and a recent version of enaml[2], but since it's not imported anywhere, the dependency isn't explicit.

1. traits-enaml https://github.com/enthought/traits-enaml
2. enaml https://github.com/nucleic/enaml

[rkern]

Demos should have an explanatory docstring.

[jwiggins]

I'll add one.

[coveralls]

Coverage decreased (-0.54%) when pulling 79c4403 on feature/ctf-gadget into a5b8cb9 on master.

[coveralls]

Coverage remained the same when pulling d4dcc58 on feature/ctf-gadget into a5b8cb9 on master.

[itziakos]

It would be nice to have some tests to complement the code.

[itziakos]

nitpick: I think for constancy with the rest of the code #: -> #

[itziakos]

I am not sure if this code belongs in enable since it practically contains more references and functionality from pyface more than enable. The feature also adds an additional dependency to traits-enaml and enaml which in my opinion is not good.

[jwiggins]

I'm open to suggestions about where this could go. I thought about it for a while before settling on enable. I think that it's useful to code which is using mayavi or chaco (and needs to create colormaps).

If I factor out the enaml bits in the way which you suggested, will this fit into enable better?

[rkern]

engadget.

[jwiggins]

rimshot

[jwiggins]

Wow, there's no indication that you edited your comment...

So, if we were to make a new ETS project called engadget, what would it contain aside from this?

[rkern]

Yeah, sorry. Everything in the angle brackets was blacklisted as malformed-html so I had to ninja-edit it to escape them. I do wish Github would send out notifications for edits.

I think there is a package's worth of potential UI widgets that are implemented in Enable/Chaco with the appropriate hooks for Traits UI and/or Enaml. For example, a double-ended slider that displays a range tool over a histogram/CDF of some dataset. Or a color selector in HuSL space and other interesting colorspaces.

[jwiggins]

So, like encore, but dependent on several other (all?) ETS packages instead of none of them?

I like that better than shoehorning this widget into enable. Just name it well!

[coveralls]

Coverage remained the same when pulling 40b83a2 on feature/ctf-gadget into a5b8cb9 on master.

[coveralls]

Coverage remained the same when pulling d6897ba on feature/ctf-gadget into a5b8cb9 on master.

[cfarrow]

Let the bikeshedding begin!

envelope - meh
enrich - better than envelope
enchilada - as in "the whole"
endeavor - I like enchilada better
engird - another meh
engage - some sort of gauge library, or gage library, either one really.
enthrall, enchant, enliven, enhance, etc. - a nice place for flashy examples
ensemble - like enchilada, but will probably be less annoying in the long run

My vote is for ensemble.

[jwiggins]

👍 ensemble

[jwiggins]

The tool behaves a bit strangely in a unit test, so I'm exercising the code but not testing it.

[itziakos]

The tool behaves a bit strangely in a unit test, so I'm exercising the code but not testing it.

Can push the unit test in a parallel branch, I might be able to help.

[coveralls]

Coverage decreased (-0.53%) when pulling f76603c on feature/ctf-gadget into a5b8cb9 on master.

[jwiggins]

I kinda think this PR should be closed and reopened on a shiny new ensemble repository.

[jwiggins]

To be continued at enthought/ensemble#1