Install SWIG with apt-get #637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwiggins
force-pushed
the
fix/cronjob-again
branch
from
a9183a1
to
91569d8
Compare
rahulporuri
reviewed
Feb 26, 2021
| @@ -44,13 +44,15 @@ jobs: | |||
| run: sudo apt-get install libglu1-mesa-dev | |||
| - name: Install build dependencies | |||
| run: | | |||
| sudo apt-get install swig | |||
There was a problem hiding this comment.
I'm not entirely sure how this will fix the issue because I thought Swig 4.x breaks the agg backend - #360. And IIUC, CI on this PR won't break because this is a cron job.
Can you edit the job schedule to make it run in this PR so that we can verify that this PR fixes the cron job?
There was a problem hiding this comment.
It works: https://github.com/enthought/enable/runs/1986218229
This is because we restrict the jobs to Ubuntu 18.04 precisely because of #360.
|
Thanks for the review |
rahulporuri
moved this from Done
to Sprint 3 : Feb 8 2021 - Feb 26 2021
in Enthought OSS Q1 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cron job is still broken because it was trying to get SWIG from PyPI. The correct source for SWIG is
apt-get.And after one test run,
celiaggalso needs to be installed but we can get that from PyPI.