Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a page for comparing backend outputs #661

Merged
merged 1 commit into from
Mar 2, 2021

Conversation

jwiggins
Copy link
Member

@jwiggins jwiggins commented Mar 2, 2021

Mentioned on #651, but there's no issue.

"mean": times.mean() * 1000,
"min": times.min() * 1000,
"max": times.max() * 1000,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm using the order of this dictionary when turning it into an HTML table

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be fine now that we only support python >= 3.6.

@rahulporuri rahulporuri added this to In progress in Enthought OSS Q1 2021 Mar 2, 2021
Copy link
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't thoroughly examine the code but I did check the output - which looks awesome. Thanks for putting this together! LGTM.

"mean": times.mean() * 1000,
"min": times.min() * 1000,
"max": times.max() * 1000,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be fine now that we only support python >= 3.6.

@jwiggins
Copy link
Member Author

jwiggins commented Mar 2, 2021

Yeah. I really like seeing all the outputs next to each other. This is really helpful for #648

@jwiggins jwiggins merged commit 5c25b64 into master Mar 2, 2021
Enthought OSS Q1 2021 automation moved this from In progress to Done Mar 2, 2021
@jwiggins jwiggins deleted the feature/backend-comparison branch March 2, 2021 11:21
@rahulporuri rahulporuri moved this from Done to Sprint 4 : March 1 - March 12 2021 in Enthought OSS Q1 2021 Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Enthought OSS Q1 2021
Sprint 4 : March 1 - March 12 2021
Development

Successfully merging this pull request may close these issues.

None yet

2 participants