Replace dynamic uses of on_trait_change with observe part 2 #663
Conversation
| @@ -93,7 +93,7 @@ def prepare(self, parent): | |||
| """ | |||
| name = self.extended_name | |||
There was a problem hiding this comment.
BEWARE: extended_name
There was a problem hiding this comment.
Meaning what, exactly? We can't be sure that name won't break when passed to observe?
There was a problem hiding this comment.
Yeah, a quick search of the code base for extended_name only gives this result here and the corresponding same thing in the wx file. Any downstream users that set this trait may run into problems if the extended name they are passing does not conform to the new mini language, and that is effectively out of our hands ...
A similar scenario was encountered in pyface and we mentioned it in the release announcement. I imagine the vast majority of users would not be affected (I dont even know how many users of this code we have in total). Nonetheless, it leaves a door open for potential breaks.
Another thing to worry about here though that I'm not sure what we would want to do for: The traitsUI code for Editor contains the code that would theoretically remove this listener (in either the dispose method or the _update_editor method itself. I also just realize I made a dumb mistake! The method being observed is _update_editor not update_editor which is defined in traitsUI. We are still in the process of updating traitsUI to observe, so that method will need its signature changed... I believe we will need that around first, before we can make this change as this code won't work currently. It must be uncovered in the test suite hence we don't see a failure here
aaronayres35
changed the title
aaronayres35
changed the title
rahulporuri
moved this from Done
to Sprint 4 : March 1 - March 12 2021
in Enthought OSS Q1 2021
part of #416
This PR finishes the job started in #656 by replacing the remaining dynamic uses of
on_trait_changewithobserve.