Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document GraphicsContext state #672

Merged
merged 2 commits into from
Mar 3, 2021
Merged

Conversation

jwiggins
Copy link
Member

@jwiggins jwiggins commented Mar 3, 2021

Closes #615

@@ -17,4 +17,4 @@
gc.add_path(path)
gc.fill_path()

gc.save("example.png")
gc.save("compiled_path_ex.png")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the changes to this file seem unrelated to the main purpose of this PR, but even so the changes make sense as something we want to do

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, it's not related. I had made a similar change in the new state example (which was copied from the compiled path example)

Copy link
Contributor

@aaronayres35 aaronayres35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple nit picky comments and a request for a quick "why this is useful/powerful" concluding paragraph

docs/source/kiva/state.rst Outdated Show resolved Hide resolved
docs/source/kiva/state.rst Show resolved Hide resolved
docs/source/kiva/state.rst Outdated Show resolved Hide resolved
docs/source/kiva/state.rst Show resolved Hide resolved
Copy link
Contributor

@aaronayres35 aaronayres35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jwiggins
Copy link
Member Author

jwiggins commented Mar 3, 2021

Thanks for the feedback

@jwiggins jwiggins merged commit ed3200c into master Mar 3, 2021
@jwiggins jwiggins deleted the docs/gc-is-a-dirty-statist branch March 3, 2021 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kiva: Basic documentation of GC state
2 participants