Get the Qt Quartz backend working again #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwiggins
commented
Mar 4, 2021
|
|
||
| from kiva.api import Font | ||
| from kiva.quartz import get_mac_context, ABCGI | ||
| from kiva.quartz import ABCGI |
There was a problem hiding this comment.
Now that get_mac_context is not needed, we should revisit whether to include it.
aaronayres35
approved these changes
Mar 4, 2021
There was a problem hiding this comment.
Changes LGTM
I ran ETS_TOOLKIT=qt4.quartz python kiva_explorer.py and things seemed to all be working / look fine.
One question: I noticed in many other files in enable/qt4 in the create_gc method there is a gc.translate_ctm(0.5, 0.5)
Is this because of the ideas on this slide of the LnL:
|
I believe there is no half pixel translation because Quartz whole coordinates are already through the center of pixels instead of along the edge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #516
This PR switches the Qt Quartz backend from a Window-based GC to an offscreen GC, because the changes in Qt5 make it very difficult (or impossible?) to reuse the
CGContextReffrom Qt's widget.